Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] Added parameter typhint where possible#32223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lyrixx commentedJun 27, 2019
| Q | A |
|---|---|
| Branch? | mas |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | ye |
| Fixed tickets | partially#32179 |
| License | MIT |
| Doc PR |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
lyrixx commentedJul 4, 2019
Are you OK with this one? cc@derrabus |
| * @param Definition $definition A Definition instance | ||
| * @param Marking|null $marking A Marking instance | ||
| * @param array $options An array of options | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be done on a lower branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's minimize the changes that don't add value to the code. Keeping that in lower branches is fine by me.
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| publicfunction__construct($subject,Marking$marking,Transition$transition,$workflowName =null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The$workflowName =>WorkflowInterface $workflow = null change should be done on a lower branch.
fabpot commentedJul 5, 2019
Thank you@lyrixx. |
This PR was merged into the 5.0-dev branch.Discussion----------[Workflow] Added parameter typhint where possible| Q | A| ------------- | ---| Branch? | mas| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | ye| Fixed tickets | partially#32179| License | MIT| Doc PR |Commits-------62e615b [Workflow] Added parameter typhint where possible