Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix BC break on WebTestCase::createClient#32214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
661571e to23a8a68Compare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👎 as explained in the comment:
the BC policy covers code changes, not annotations
the BC policy doesn't cover phpstan levels or similar concepts.
| * @param array $server An array of server parameters | ||
| * | ||
| * @returnKernelBrowser AKernelBrowser instance | ||
| * @returnClient AClient instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be reverted: docblock always document the non-deprecated API.
teohhanhui commentedJun 28, 2019
@nicolas-grekas Thanks for the clarification. |
Changing the return type of
WebTestCase::createClientmethod was a BC break. Introduced in#30541.