Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Add @method PHPDoc for getRequest and getResponse back to Client#32213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:4.3fromteohhanhui:fix/http-kernel-client-phpdoc-bcJun 28, 2019
Merged
[HttpKernel] Add @method PHPDoc for getRequest and getResponse back to Client#32213
nicolas-grekas merged 1 commit intosymfony:4.3fromteohhanhui:fix/http-kernel-client-phpdoc-bcJun 28, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
teohhanhui commentedJun 27, 2019
Travis failures seem unrelated. |
nicolas-grekas approved these changesJun 28, 2019
Member
nicolas-grekas commentedJun 28, 2019
Thank you@teohhanhui. |
nicolas-grekas added a commit that referenced this pull requestJun 28, 2019
…sponse back to Client (teohhanhui)This PR was merged into the 4.3 branch.Discussion----------[HttpKernel] Add@method PHPDoc for getRequest and getResponse back to Client| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A| License | MIT| Doc PR | N/AAs the deprecated `Symfony\Component\HttpKernel\Client` does not extend `Symfony\Component\HttpKernel\HttpKernelBrowser`, it has not retained the correct PHPDoc from before.The order of inheritance was changed in#31881, but the PHPDoc was never restored.Commits-------3321351 [HttpKernel] Add@method PHPDoc for getRequest and getResponse back to Client
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the deprecated
Symfony\Component\HttpKernel\Clientdoes not extendSymfony\Component\HttpKernel\HttpKernelBrowser, it has not retained the correct PHPDoc from before.The order of inheritance was changed in#31881, but the PHPDoc was never restored.