NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] remove form type validation due to typehints#32178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromTobion:form-validate-name

Jun 26, 2019

Merged

[Form] remove form type validation due to typehints#32178

fabpot merged 1 commit intosymfony:masterfromTobion:form-validate-name

Jun 26, 2019

Conversation

Copy link

Contributor

Tobion commentedJun 25, 2019

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Tobion requested a review fromxabbuh as acode owner

June 25, 2019 22:59

carsonbot added Status: Needs Review Form labels

Jun 25, 2019

Tobion mentioned this pull request

Jun 25, 2019

Removed legacy code and cleanup#32160

Merged

[Form] remove form type validation due to typehints

ba2b5c1

Tobion force-pushed theform-validate-name branch from51d1711 toba2b5c1Compare

June 25, 2019 23:02

fabpot approved these changes

Jun 26, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 26, 2019

Copy link

Member

fabpot commentedJun 26, 2019

Thank you@Tobion.

fabpot merged commitba2b5c1 intosymfony:master

Jun 26, 2019

fabpot added a commit that referenced this pull request

Jun 26, 2019

minor#32178[Form] remove form type validation due to typehints (Tob…

71525d4

…ion)This PR was merged into the 5.0-dev branch.Discussion----------[Form] remove form type validation due to typehints| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |Commits-------ba2b5c1 [Form] remove form type validation due to typehints