Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security/Core] require libsodium >= 1.0.14#32169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromnicolas-grekas:sec-argon
Jun 25, 2019

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedJun 25, 2019•
edited
Loading

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32166
LicenseMIT
Doc PR-

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit4fed5d3 intosymfony:4.3Jun 25, 2019
fabpot added a commit that referenced this pull requestJun 25, 2019
This PR was merged into the 4.3 branch.Discussion----------[Security/Core] require libsodium >= 1.0.14| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#32166| License       | MIT| Doc PR        | -- bump libsodium to >=1.0.14- Minimum opscost must be 3, as described inhttps://wiki.php.net/rfc/libsodium and inhttps://github.com/jedisct1/libsodium/releases/tag/1.0.15- ParagonIE_Sodium_Compat [explicitly doesn't implement Argon2](https://github.com/paragonie/sodium_compat#features-excluded-from-this-polyfill), so it makes no sense to check for it.Commits-------4fed5d3 [Security/Core] require libsodium >= 1.0.14
@fabpotfabpot mentioned this pull requestJun 26, 2019
@mbabker
Copy link
Contributor

@nicolas-grekas The checks for the sodium_compat library are actually needed because the library exposes the functions but has stubs that only throw Exceptions if neitherext/sodium orext/libsodium are installed,#25412 for reference.

@nicolas-grekas
Copy link
MemberAuthor

Seriously, wow.
I would not load the polyfill to ensure it's not here.
Instead let's useextensio_loaded('sodium') || extension_loaded('libsodium') as additional checks?

@mbabker
Copy link
Contributor

That seems fair, as long as it's not relying purely on the function checks you're probably OK.

nicolas-grekas added a commit that referenced this pull requestJun 26, 2019
…rekas)This PR was merged into the 3.4 branch.Discussion----------[Security/Core] work around sodium_compat issue| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -As reported by@mbabker in#321691.0.9 perhttps://github.com/jedisct1/libsodium/releases/tag/1.0.9Commits-------df50685 [Security/Core] work around sodium_compat issue
@nicolas-grekasnicolas-grekas deleted the sec-argon branchJuly 4, 2019 14:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

+1 more reviewer

@rbaarsmarbaarsmarbaarsma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@fabpot@mbabker@stof@rbaarsma@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp