Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] Failing test case for complex near-circular situation + lazy#32157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@weaverryan
Copy link
Member

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30091
LicenseMIT
Doc PRnot needed

Just the failing test case. But hopefully, this can get things moving :)

kaznovac reacted with thumbs up emojidmaicher, nicolas-grekas, Lctrs, and Simperfit reacted with hooray emoji

// doctrine-like event system with small differences

$container->register('manager4','stdClass')
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a second case that's actually unrelated, but I stumbled upon it. For some reason, ifconnection4 is NOT public, you get a nesting exception.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could be worth to add this explanation as a comment code ?

@nicolas-grekasnicolas-grekas added this to the4.2 milestoneJun 24, 2019
@fabpotfabpot modified the milestones:4.2,4.3Jul 28, 2019
@nicolas-grekasnicolas-grekas changed the base branch from4.2 to4.3July 28, 2019 15:22
@nicolas-grekasnicolas-grekasforce-pushed thedoctrine-almost-circular-failing-test branch 3 times, most recently fromdd60aa9 toc694216CompareJuly 29, 2019 13:24
@nicolas-grekasnicolas-grekasforce-pushed thedoctrine-almost-circular-failing-test branch fromc694216 to4c03af4CompareJuly 29, 2019 16:30
@nicolas-grekas
Copy link
Member

Thank you@weaverryan
I've added you test cases to#30096, they were perfect.
I've also pushed here the patch that should be applied to branch 4.3, when merging up.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@LctrsLctrsLctrs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nicolas-grekasnicolas-grekas

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@weaverryan@nicolas-grekas@Lctrs@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp