Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make Symfony\Component\Debug\ExceptionHandler::setFileLinkFormat accept Null as a return type#32153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromjlslew:master
Jun 26, 2019

Conversation

@jlslew
Copy link

fixes#32150

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32150
LicenseMIT
Doc PR-

MakeSymfony\Component\Debug\ExceptionHandler::setFileLinkFormat accept null as a return type.
Since Symfony requires PHP 7.2+ and that PHP feature was introduced in 7.1, I use that feature instead of changing the default value of the variable.

@xabbuhxabbuh added this to the5.0 milestoneJun 24, 2019
@xabbuhxabbuh added the Debug labelJun 24, 2019
@fabpot
Copy link
Member

Thank you@jlslew.

jlslew reacted with thumbs up emoji

@fabpotfabpot merged commite6cb7d8 intosymfony:masterJun 26, 2019
fabpot added a commit that referenced this pull requestJun 26, 2019
…nkFormat accept Null as a return type (jls-esokia)This PR was merged into the 5.0-dev branch.Discussion----------Make Symfony\Component\Debug\ExceptionHandler::setFileLinkFormat accept Null as a return typefixes#32150| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#32150    <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | - <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Make `Symfony\Component\Debug\ExceptionHandler::setFileLinkFormat` accept null as a return type.Since Symfony requires PHP 7.2+ and that PHP feature was introduced in 7.1, I use that feature instead of changing the default value of the variable.Commits-------e6cb7d8 Remove return type from ExceptionHandler::setFileLinkFormat
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+2 more reviewers

@fancywebfancywebfancyweb left review comments

@TobionTobionTobion requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jlslew@fabpot@Tobion@fancyweb@xabbuh@carsonbot@jls-esokia

[8]ページ先頭

©2009-2025 Movatter.jp