Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] accept floats for input="string" in NumberType#32125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromxabbuh:issue-31905
Jun 22, 2019

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedJun 20, 2019•
edited
Loading

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#31905,#32124
LicenseMIT
Doc PR

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!!

@fancyweb
Copy link
Contributor

fancyweb commentedJun 21, 2019•
edited
Loading

Shouldn't we trigger a deprecation here so users actually uses string instead of floats in their entities?

@xabbuhxabbuh changed the title[Form] don't reject floats in StringToFloatTransformer[Form] accepts floats for input="string" in NumberTypeJun 21, 2019
@xabbuh
Copy link
MemberAuthor

I have updated the code a bit. The changes made for theStringToFloatTransformer have been reverted. Instead theNumberType takes care of the type cast.

This allows us to deprecate the behaviour with a better message in 4.4 as suggested in#32125 (comment) and we do not need to weaken theStringToFloatTransformer.

fancyweb reacted with thumbs up emoji

@xabbuhxabbuh changed the title[Form] accepts floats for input="string" in NumberType[Form] accept floats for input="string" in NumberTypeJun 21, 2019
@xabbuh
Copy link
MemberAuthor

@fancyweb see#32130

fabpot added a commit that referenced this pull requestJun 22, 2019
…ype (xabbuh)This PR was merged into the 4.4 branch.Discussion----------[Form] deprecate int/float for string input in NumberType| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#32125 (comment)| License       | MIT| Doc PR        |Commits-------d8c008a deprecate int/float for string input in NumberType
@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit2abf855 intosymfony:4.3Jun 22, 2019
fabpot added a commit that referenced this pull requestJun 22, 2019
…buh)This PR was merged into the 4.3 branch.Discussion----------[Form] accept floats for input="string" in NumberType| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#31905,#32124| License       | MIT| Doc PR        |Commits-------2abf855 accept floats for input="string" in NumberType
@xabbuhxabbuh deleted the issue-31905 branchJune 22, 2019 11:09
@fabpotfabpot mentioned this pull requestJun 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@ycerutoycerutoyceruto approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@xabbuh@fancyweb@fabpot@yceruto@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp