Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Debug] workaround BC break in PHP 7.3#32090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dzuelke commentedJun 18, 2019
Is there anything inhttps://github.com/php/php-src/blob/PHP-7.4/UPGRADING that could use addressing maybe? It seems like nested ternary operators would be in some library somewhere... |
derrabus commentedJun 18, 2019
Wouldn't it be enough if we don't upmerge this workaround to 4.x? |
derrabus commentedJun 18, 2019
Symfony itself has quite a few. ;-) But a nested ternary should only trigger a |
nicolas-grekas commentedJun 19, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We can remove in 4, but there's no hurry, and new BC breaks are for 5, that's why I added this comment. |
fabpot commentedJun 19, 2019
Thank you@nicolas-grekas. |
This PR was merged into the 3.4 branch.Discussion----------[Debug] workaround BC break in PHP 7.3| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |https://github.com/symfony/symfony-standard/issues/1138symfony/website-skeleton#231| License | MIT| Doc PR | -A new warning has been added in PHP 7.3 that is breaking BC with Symfony, since we turn warnings into exceptions.This PR turns the new warning into a deprecation, so that we will be able to remove the added "if" in 5.0.I noticed a few other similar BC breaks in 7.1 and 7.2, but *unless someone reports that they block them*, I don't think we need to care.- 7.1 A non well formed numeric value encountered E_NOTICE- 7.1 A non-numeric value encountered E_WARNING- 7.2 count() now raises a warning when an invalid parameter is passed.Seehttps://github.com/php/php-src/blob/PHP-7.1/UPGRADING + same in upper branches.Commits-------d8d43e6 [Debug] workaround BC break in PHP 7.3
A new warning has been added in PHP 7.3 that is breaking BC with Symfony, since we turn warnings into exceptions.
This PR turns the new warning into a deprecation, so that we will be able to remove the added "if" in 5.0.
I noticed a few other similar BC breaks in 7.1 and 7.2, butunless someone reports that they block them, I don't think we need to care.
Seehttps://github.com/php/php-src/blob/PHP-7.1/UPGRADING + same in upper branches.