Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] make all stamps final and mark stamp not meant to be sent#32078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Tobion merged 1 commit intosymfony:4.4fromTobion:make-all-stamps-final
Jun 24, 2019

Conversation

@Tobion
Copy link
Contributor

QA
Branch?4.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Some newer stamps were already final. This makes all of them final. Also marks all stamps that are not meant to be sent using the newNonSendableStampInterface. This makes it easier to see which stamps are actually important and required to persist in a queue for certain functionality, like theBusNameStamp for theRoutableMessageBus

ro0NL reacted with thumbs up emoji
* @experimental in 4.3
*/
class TransportMessageIdStampimplements StampInterface
finalclass TransportMessageIdStampimplements StampInterface
Copy link
ContributorAuthor

@TobionTobionJun 18, 2019•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not needed to be sent but could be useful for debugging a message history (changing ID after retry)

@TobionTobionforce-pushed themake-all-stamps-final branch froma9f5d1d to452ba34CompareJune 18, 2019 03:26
@TobionTobionforce-pushed themake-all-stamps-final branch from452ba34 to013904bCompareJune 24, 2019 13:58
@TobionTobion merged commit013904b intosymfony:4.4Jun 24, 2019
Tobion added a commit that referenced this pull requestJun 24, 2019
…nt to be sent (Tobion)This PR was merged into the 4.4 branch.Discussion----------[Messenger] make all stamps final and mark stamp not meant to be sent| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |Some newer stamps were already final. This makes all of them final. Also marks all stamps that are not meant to be sent using the new `NonSendableStampInterface`. This makes it easier to see which stamps are actually important and required to persist in a queue for certain functionality, like the `BusNameStamp` for the `RoutableMessageBus`Commits-------013904b [Messenger] make all stamps final and mark stamp not meant to be sent
@TobionTobion deleted the make-all-stamps-final branchJune 24, 2019 22:34
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@weaverryanweaverryanweaverryan approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Tobion@weaverryan@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp