Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Lock] Fix PDO prune not called#32076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.2fromjderusse:fix-gc-pdo
Jun 17, 2019

Conversation

@jderusse
Copy link
Member

@jderussejderusse commentedJun 17, 2019
edited
Loading

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsNA
LicenseMIT
Doc PRNA

Saving a key in the PDO store have 2 paths:

  • the key is didn't exists in the store, the process exit as soon as the key has been savec
  • the key already exists in the store, the process put off the expiration then run GC to prunbe old keys

Calling GC only in the 2nd path was a mistake, if the component is well used, the second could never be used.
This PR call the GC in the first path too.

@nicolas-grekas
Copy link
Member

Thank you@jderusse.

@nicolas-grekasnicolas-grekas merged commitfc2dc14 intosymfony:4.2Jun 17, 2019
nicolas-grekas added a commit that referenced this pull requestJun 17, 2019
This PR was merged into the 4.2 branch.Discussion----------[Lock] Fix PDO prune not called| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | NA| License       | MIT| Doc PR        | NASaving a key in the PDO store have 2 paths:- the key is didn't exists in the store, the process exit as soon as the key has been savec- the key already exists in the store, the process put off the expiration then run GC to prunbe old keysCalling GC only in the 2nd path was a mistake, if the component is well used, the second could never be used.This PR call the GC in the first path too.Commits-------fc2dc14 Fix PDO prune not called
This was referencedJun 26, 2019
@jderussejderusse deleted the fix-gc-pdo branchAugust 2, 2019 12:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jderusse@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp