Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] throw DecodingExceptionInterface when toArray() fails because of content-type error#32065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromnicolas-grekas:hc-decoding
Jun 17, 2019

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#31913
LicenseMIT
Doc PR-

As spotted in the linked issue, we are missing this type of exception. It's a bug at the contracts level.

@chalasr
Copy link
Member

This changes the public API and involve code changes in userland though (and could be worth a CHANGELOG entry), which hints that this is a new feature to me.

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedJun 17, 2019•
edited
Loading

This changes the public API and involve code changes in userland though (and could be worth a CHANGELOG entry), which hints that this is a new feature to me.

for experimental components, we can bypass this rule, because here this is also a BC break, and we should close any such issues asap. That's why I added "bug fix at the contracts level" in the description.

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit3f16741 intosymfony:4.3Jun 17, 2019
fabpot added a commit that referenced this pull requestJun 17, 2019
…() fails because of content-type error (nicolas-grekas)This PR was merged into the 4.3 branch.Discussion----------[HttpClient] throw DecodingExceptionInterface when toArray() fails because of content-type error| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#31913| License       | MIT| Doc PR        | -As spotted in the linked issue, we are missing this type of exception. It's a bug at the contracts level.Commits-------3f16741 [HttpClient] throw DecodingExceptionInterface when toArray() fails because of content-type error
@nicolas-grekasnicolas-grekas deleted the hc-decoding branchJune 18, 2019 07:23
@fabpotfabpot mentioned this pull requestJun 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@ro0NLro0NLro0NL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@nicolas-grekas@chalasr@fabpot@javiereguiluz@ro0NL@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp