Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Bump PHPUnit 7+8#32059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ro0NL commentedJun 15, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #... |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
Taluu commentedJun 15, 2019
Shouldn't this target 2.8 ? |
ro0NL commentedJun 15, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
i figured master because of
so this changes the default version; for 2.8 users can leverage |
nicolas-grekas commentedJun 15, 2019
We should maybe remember to bump before the 4.4.0 if a new version is released meanwhile. |
ro0NL commentedJun 15, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We should definitively not forget to bump to v8 :) Im wondering about the purpose of hardcoding the upper bound constraint for PHPUnit :/ it blocks the AFAIK it's not possible to do e.g. |
nicolas-grekas commentedJun 15, 2019
did you try relaxing those? now that we use composer to download phpunit, maybe it could be made to work? |
ro0NL commentedJun 16, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nicolas-grekas IIUC ideally the default for sf4.4 as of php7.2 would be And im not sure doing it as of php7.2, if we dont need the version upfront i tend to prefer not hardcoding any upper limits 🤔 |
nicolas-grekas commentedJun 16, 2019
I'm not sure: what about BC when a new major of phpunit is released? |
ro0NL commentedJun 16, 2019
Ultimately let the user decide its fixed version using Having |
nicolas-grekas commentedJun 16, 2019
Isn't it already the case? See |
ro0NL commentedJun 16, 2019
I see, let's leave as is. Explicit version control is nice anyway. Basically i was looking for a cheap solution to lethttps://hub.docker.com/r/jakzal/phpqa/ install both a wrapped v7 and v8 by default. But it's distributed from 7.1 to 7.3, so v8 should be excluded for 7.1 The toolbox also installs v7 + v8 natively under different binaries:https://github.com/jakzal/toolbox/blob/master/resources/tools.json#L618-L641 This works because it can exclude 7.1 tag-based per tool, but not per install command for a single tool. As simple-phpunit is a version manager it doesnt make sense to have e.g. Therefor im leaning to exclude the whole simple-phpunit binary in the toolbox, on 7.1. (cc@jakzal), then it can be installed using |
ro0NL commentedJun 16, 2019
I figured PHPunit 7 can also be bumped. |
fabpot commentedJun 16, 2019
Thank you@ro0NL. |
This PR was squashed before being merged into the 4.4 branch (closes#32059).Discussion----------[PhpUnitBridge] Bump PHPUnit 7+8| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------5491d53 [PhpUnitBridge] Bump PHPUnit 7+8