NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpFoundation] Fix SA/phpdoc JsonResponse#32057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromro0NL:patch-2

Jun 16, 2019

Merged

[HttpFoundation] Fix SA/phpdoc JsonResponse#32057

fabpot merged 1 commit intosymfony:3.4fromro0NL:patch-2

Jun 16, 2019

Conversation

Copy link

Contributor

ro0NL commentedJun 15, 2019•
edited
Loading

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#...
License	MIT
Doc PR	symfony/symfony-docs#...

carsonbot added Status: Needs Review HttpFoundation Bug Deprecation labels

Jun 15, 2019

javiereguiluz removed Bug Deprecation labels

Jun 15, 2019

javiereguiluz added this to the3.4 milestone

Jun 15, 2019

javiereguiluz approved these changes

Jun 15, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 15, 2019

fabpot approved these changes

Jun 16, 2019

View reviewed changes

[HttpFoundation] Fix SA/phpdoc JsonResponse

270f10c

Copy link

Member

fabpot commentedJun 16, 2019

Thank you@ro0NL.

fabpot merged commit270f10c intosymfony:3.4

Jun 16, 2019

fabpot added a commit that referenced this pull request

Jun 16, 2019

bug#32057[HttpFoundation] Fix SA/phpdoc JsonResponse (ro0NL)

a8520ae

This PR was squashed before being merged into the 3.4 branch (closes#32057).Discussion----------[HttpFoundation] Fix SA/phpdoc JsonResponse| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Commits-------270f10c [HttpFoundation] Fix SA/phpdoc JsonResponse