Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Show the right class autowired when providing a non-existing class#32040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[DI] Show the right class autowired when providing a non-existing class#32040
Uh oh!
There was an error while loading.Please reload this page.
Conversation
18221a8 to36a9a6aComparesrc/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Simperfit commentedJun 14, 2019
AppVeyor failure seems not related |
src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
36a9a6a to717c71aCompare717c71a tofbda90aCompareSimperfit commentedJun 15, 2019
Status: Needs review |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice thanks.
fabpot commentedJun 16, 2019
Thank you@Simperfit. |
…xisting class (Simperfit)This PR was merged into the 4.3 branch.Discussion----------[DI] Show the right class autowired when providing a non-existing class| Q | A| ------------- | ---| Branch? 4.3| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#31997 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |none <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->This gets the last current id before the error and pass it to the callback in order to get the right error message.Commits-------fbda90a [DI] Show the right class autowired when providing a non-existing class in constructor
This gets the last current id before the error and pass it to the callback in order to get the right error message.