Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DI] Show the right class autowired when providing a non-existing class#32040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

QA
Branch? 4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#31997
LicenseMIT
Doc PRnone

This gets the last current id before the error and pass it to the callback in order to get the right error message.

@SimperfitSimperfitforce-pushed thebugfix/show-the-right-class-when-providing-a-non-exisint-class-in-autowire branch 2 times, most recently from18221a8 to36a9a6aCompareJune 14, 2019 08:37
@Simperfit
Copy link
ContributorAuthor

AppVeyor failure seems not related

@SimperfitSimperfitforce-pushed thebugfix/show-the-right-class-when-providing-a-non-exisint-class-in-autowire branch from36a9a6a to717c71aCompareJune 15, 2019 04:06
@SimperfitSimperfitforce-pushed thebugfix/show-the-right-class-when-providing-a-non-exisint-class-in-autowire branch from717c71a tofbda90aCompareJune 15, 2019 04:08
@Simperfit
Copy link
ContributorAuthor

Status: Needs review

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice thanks.

@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commitfbda90a intosymfony:4.3Jun 16, 2019
fabpot added a commit that referenced this pull requestJun 16, 2019
…xisting class (Simperfit)This PR was merged into the 4.3 branch.Discussion----------[DI] Show the right class autowired when providing a non-existing class| Q             | A| ------------- | ---| Branch?        4.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#31997   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |none <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->This gets the last current id before the error and pass it to the callback in order to get the right error message.Commits-------fbda90a [DI] Show the right class autowired when providing a non-existing class in constructor
@SimperfitSimperfit deleted the bugfix/show-the-right-class-when-providing-a-non-exisint-class-in-autowire branchJune 16, 2019 14:11
@fabpotfabpot mentioned this pull requestJun 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr requested changes

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@Simperfit@fabpot@nicolas-grekas@ogizanagi@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp