Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Add couchbase cache adapter#32039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromajcerezo:feature/add-cache-couchbase-bucket-adapter
Feb 4, 2020
Merged

[Cache] Add couchbase cache adapter#32039

fabpot merged 1 commit intosymfony:masterfromajcerezo:feature/add-cache-couchbase-bucket-adapter
Feb 4, 2020

Conversation

@ajcerezo
Copy link
Contributor

@ajcerezoajcerezo commentedJun 14, 2019•
edited
Loading

QA
Branch?4.4 for features
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32038
LicenseMIT
Doc PRsymfony/symfony-docs#11748

Add new cache adapter to be able using Couchbase as cache system.

goetas, mgroves, avsej, razvanalin, RoqueAlonso, Percewall, mcpaddy, wcarvalloalandia, dnault, ajcerezo, and kolomerot reacted with thumbs up emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this.
Can you ensure the .travis.yml file is configured to run the tests for the new adapter please?

@ajcerezoajcerezo changed the titleAdd couchbase cache adapter.[WIP] Add couchbase cache adapter.Jun 19, 2019
@ajcerezoajcerezo changed the title[WIP] Add couchbase cache adapter.WIP: Add couchbase cache adapter.Jun 19, 2019
@ajcerezo
Copy link
ContributorAuthor

Hi@nicolas-grekas ,
The integration tests with travis do not work, but I do not understand why it fails, since I have not changed anything in the Mailer component.
The error it gives is the following:

1) Symfony\Component\Mailer\Tests\TransportTest::testFromDsnMailgunTypeError: Argument 4 passed to Symfony\Component\Mailer\Bridge\Mailgun\Smtp\MailgunTransport::__construct() must implement interface Psr\Log\LoggerInterface or be null, instance of Mock_EventDispatcherInterface_fc379422 given, called in /home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php on line 104/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/vendor/symfony/mailgun-mailer/Smtp/MailgunTransport.php:25/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php:104/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Transport.php:58/home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Tests/TransportTest.php:105

And from what I can see in the code as a fourth parameter, it is passing a mock of an LoggerInterface

Could you help me?

Thank you.

@OskarStark
Copy link
Contributor

@ajcerezo are you planing to finish this PR?

@ajcerezo
Copy link
ContributorAuthor

Hello@OskarStark , I am sorry for the delay in the response at this time, I only have one problem with the integration tests in travis, but it is nothing of the code that I have touched, the exact comment of this problem is just above and I do not know why I fail . If you can help me, I imagine that it has been part of one of the rebase that I had to do to merge with the latest changes in branch 4.4.

The new functionality is finished.

Copy link
Contributor

@OskarStarkOskarStark left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To me this is not a BC break, can you please update the table in the PR header, if you agree with me? Thanks 👍🏻

@ajcerezoajcerezo changed the titleWIP: Add couchbase cache adapter.Add couchbase cache adapter.Aug 21, 2019
/**
* @author Antonio Jose Cerezo Aranda <aj.cerezo@gmail.com>
*/
class CouchbaseBucketAdapterextends AbstractAdapter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can and shall we make this class final@nicolas-grekas ? Not sure right now how Symfony handles such things

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@OskarStark,

From what I've seen none of the other adapters is defined as final class.

@ajcerezo
Copy link
ContributorAuthor

ajcerezo commentedAug 27, 2019•
edited
Loading

Hi@OskarStark,
I change BC break status in the table of header but the labels of pull request not change.

Thank you

@OskarStark
Copy link
Contributor

@nicolas-grekas can you please take care of the label and give another review here? Thanks.

@fabpot
Copy link
Member

I'd like to get an idea on the number of people in the community using couchbase before merging this PR in core.

@ajcerezo
Copy link
ContributorAuthor

Ok, thank you.

@OskarStark
Copy link
Contributor

I'd like to get an idea on the number of people in the community using couchbase before merging this PR in core.

I asked via Twitter:https://twitter.com/OskarStark/status/1190148688565415936

mgroves and ajcerezo reacted with laugh emoji

@Jeroen-Sen
Copy link

👍 (We’ll open source our Symfony-Doctrine-Couchebase integration soon.😁)

@Mrkisha
Copy link

👍

@mgroves
Copy link

mgroves commentedNov 1, 2019•
edited
Loading

I'd like to get an idea on the number of people in the community using couchbase before merging this PR in core.

I asked via Twitter:https://twitter.com/OskarStark/status/1190148688565415936

I'm a DA with Couchbase. I think we'll add this PR to our monthly newsletter. In the meantime, is there anything else I can do to get this in front of Couchbase/PHP/symfony users?

Also, feel free to post a message on our PHP forum if you'd like:https://forums.couchbase.com/c/php-sdk

ajcerezo reacted with thumbs up emojidnault reacted with heart emoji

@fparis-sp
Copy link

👍

2 similar comments
@razvanalin
Copy link

👍

@wcarvalloalandia
Copy link

👍

@nicolas-grekasnicolas-grekas changed the titleAdd couchbase cache adapter.[Cache] Add couchbase cache adapterFeb 3, 2020
@nicolas-grekasnicolas-grekas changed the base branch from4.4 tomasterFebruary 3, 2020 17:36
@fabpot
Copy link
Member

Thank you@ajcerezo.

fabpot added a commit that referenced this pull requestFeb 4, 2020
This PR was merged into the 5.1-dev branch.Discussion----------[Cache] Add couchbase cache adapter| Q             | A| ------------- | ---| Branch?       | 4.4 for features| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#32038| License       | MIT| Doc PR        |symfony/symfony-docs#11748Add new cache adapter to be able using Couchbase as cache system.Commits-------1ae7dd5 [Cache] Add couchbase cache adapter
@fabpotfabpot merged commit1ae7dd5 intosymfony:masterFeb 4, 2020
@ajcerezo
Copy link
ContributorAuthor

Thanks to the all symfony community.

OskarStark reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

12 participants

@ajcerezo@OskarStark@fabpot@Jeroen-Sen@Mrkisha@mgroves@fparis-sp@razvanalin@wcarvalloalandia@nicolas-grekas@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp