Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Handle true and false appropriately in CSV encoder#32007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4frombattye:bugfix/csv-encoder
Jun 14, 2019

Conversation

@battye
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#27642
LicenseMIT
Doc PR-

Previously, iftrue was passed in as a value to the CSV encoder thenfputcsv() would correctly treat it as 1. However, iffalse was passed in, it would be treated as a blank value.null would also be treated as a blank value.

This fix makes it consistent so that true and false will map to 1 and 0, while null maps to an empty string.

@battyebattye changed the title[Serializer] Handle true, false, null appropriately in CSV encoder[Serializer] Handle true and false appropriately in CSV encoderJun 14, 2019
@fabpot
Copy link
Member

Thank you@battye.

@fabpotfabpot merged commit89cba00 intosymfony:3.4Jun 14, 2019
fabpot added a commit that referenced this pull requestJun 14, 2019
…coder (battye)This PR was squashed before being merged into the 3.4 branch (closes#32007).Discussion----------[Serializer] Handle true and false appropriately in CSV encoder| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27642| License       | MIT| Doc PR        | -Previously, if `true` was passed in as a value to the CSV encoder then `fputcsv()` would correctly treat it as 1. However, if `false` was passed in, it would be treated as a blank value. `null` would also be treated as a blank value.This fix makes it consistent so that true and false will map to 1 and 0, while null maps to an empty string.Commits-------89cba00 [Serializer] Handle true and false appropriately in CSV encoder
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneJun 17, 2019
This was referencedJun 26, 2019
@battyebattye deleted the bugfix/csv-encoder branchJuly 31, 2020 13:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasdunglas approved these changes

+2 more reviewers

@kevin-verschaevekevin-verschaevekevin-verschaeve approved these changes

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

7 participants

@battye@fabpot@dunglas@kevin-verschaeve@Simperfit@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp