NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[PhpunitBridge] Restore php 5.5 compat#31999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.3fromgreg0ire:restore-php-5.5-compat

Jun 12, 2019

Merged

[PhpunitBridge] Restore php 5.5 compat#31999

fabpot merged 1 commit intosymfony:4.3fromgreg0ire:restore-php-5.5-compat

Jun 12, 2019

Conversation

Copy link

Contributor

greg0ire commentedJun 11, 2019•
edited
Loading

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	yes/no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

TheARRAY_FILTER_USE_KEY constant was introduced in php 5.6, let us
avoid it for now.
Seehttps://www.php.net/manual/en/function.array-filter.php#refsect1-function.array-filter-changelog

Thanks@alcaeus for spotting this inhttps://travis-ci.org/doctrine/DoctrineBundle/jobs/543340482#L596

Restore compatibility with php 5.5

496c118

The ARRAY_FILTER_USE_KEY constant was introduced in php 5.6, let usavoid it for now.Seehttps://www.php.net/manual/en/function.array-filter.php#refsect1-function.array-filter-changelog

carsonbot added Status: Needs Review PhpUnitBridge Bug Deprecation and removed Status: Needs Review labels

Jun 11, 2019

fabpot approved these changes

Jun 12, 2019

View reviewed changes

carsonbot added the Status: Reviewed label

Jun 12, 2019

Copy link

Member

fabpot commentedJun 12, 2019

Thank you@greg0ire.

fabpot merged commit496c118 intosymfony:4.3

Jun 12, 2019

fabpot added a commit that referenced this pull request

Jun 12, 2019

bug#31999[PhpunitBridge] Restore php 5.5 compat (greg0ire)

c45c6e5

This PR was merged into the 4.3 branch.Discussion----------[PhpunitBridge] Restore php 5.5 compat| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aThe `ARRAY_FILTER_USE_KEY` constant was introduced in php 5.6, let usavoid it for now.Seehttps://www.php.net/manual/en/function.array-filter.php#refsect1-function.array-filter-changelogThanks@alcaeus for spotting this inhttps://travis-ci.org/doctrine/DoctrineBundle/jobs/543340482#L596Commits-------496c118 Restore compatibility with php 5.5