Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add missing rendering of form help block.#31972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.2fromalexsegura:bootstrap-form-help
Jun 26, 2019

Conversation

@alexsegura
Copy link
Contributor

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

When usingbootstrap_3_layout.html.twig form theme, the help blocks are not rendered.

{%form_themeform'bootstrap_3_layout.html.twig' %}{{ form_start(form) }}  {{ form_row(form.some_field) }}{# <-- no help text is rendered#}{{ form_end(form) }}

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

a test covering this would be nice

@fabpot
Copy link
Member

Thank you@alexsegura.

@fabpotfabpot merged commitff5517e intosymfony:4.2Jun 26, 2019
fabpot added a commit that referenced this pull requestJun 26, 2019
This PR was merged into the 4.2 branch.Discussion----------Add missing rendering of form help block.| Q             | A| ------------- | ---| Branch?       | 4.2 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| License       | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->When using `bootstrap_3_layout.html.twig` form theme, the help blocks are not rendered.```twig{% form_theme form 'bootstrap_3_layout.html.twig' %}{{ form_start(form) }}  {{ form_row(form.some_field) }} {# <-- no help text is rendered #}{{ form_end(form) }}```Commits-------ff5517e Add missing rendering of form help block.
@alexseguraalexsegura deleted the bootstrap-form-help branchJune 26, 2019 08:32
This was referencedJun 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@alexsegura@fabpot@xabbuh@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp