Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add missing rendering of form help block.#31972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xabbuh approved these changesJun 18, 2019
Member
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a test covering this would be nice
fabpot approved these changesJun 26, 2019
Member
fabpot commentedJun 26, 2019
Thank you@alexsegura. |
fabpot added a commit that referenced this pull requestJun 26, 2019
This PR was merged into the 4.2 branch.Discussion----------Add missing rendering of form help block.| Q | A| ------------- | ---| Branch? | 4.2 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| License | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->When using `bootstrap_3_layout.html.twig` form theme, the help blocks are not rendered.```twig{% form_theme form 'bootstrap_3_layout.html.twig' %}{{ form_start(form) }} {{ form_row(form.some_field) }} {# <-- no help text is rendered #}{{ form_end(form) }}```Commits-------ff5517e Add missing rendering of form help block.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
bootstrap_3_layout.html.twigform theme, the help blocks are not rendered.{%form_themeform'bootstrap_3_layout.html.twig' %}{{ form_start(form) }} {{ form_row(form.some_field) }}{# <-- no help text is rendered#}{{ form_end(form) }}