NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] Doctrine Connection find and findAll now correctly decode headers#31966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.3fromTimoBakx:messenger-doctrine-find

Jun 26, 2019

Merged

[Messenger] Doctrine Connection find and findAll now correctly decode headers#31966

fabpot merged 1 commit intosymfony:4.3fromTimoBakx:messenger-doctrine-find

Jun 26, 2019

Conversation

Copy link

Member

TimoBakx commentedJun 9, 2019

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#31916
License	MIT
Doc PR	N/A

The Doctrine transportConnection class methodsfind andfindAll did not JSON-decode the headers of the envelope after retrieving it from Doctrine. Theget method, however, did this correctly.

I added two tests to verify the results offind andfindAll and then added the JSON-decoding to theConnection class. I moved the JSON-decoding to a separate method to avoid duplicate code.

carsonbot added Status: Needs Review Messenger Bug labels

Jun 9, 2019

nicolas-grekas added this to the4.3 milestone

Jun 9, 2019

sroze self-requested a review

June 9, 2019 20:30

sroze reviewed

Jun 9, 2019

View reviewed changes

src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php OutdatedShow resolvedHide resolved

[Messenger] Doctrine Connection find and findAll now correctly decode…

3aec2ac

… headers

TimoBakx commented

Jun 9, 2019

View reviewed changes

src/Symfony/Component/Messenger/Transport/Doctrine/Connection.phpShow resolvedHide resolved

fabpot approved these changes

Jun 26, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 26, 2019

Copy link

Member

fabpot commentedJun 26, 2019

Thank you@TimoBakx.

fabpot merged commit3aec2ac intosymfony:4.3

Jun 26, 2019

fabpot added a commit that referenced this pull request

Jun 26, 2019

bug#31966[Messenger] Doctrine Connection find and findAll now corre…

bd2356d

…ctly decode headers (TimoBakx)This PR was merged into the 4.3 branch.Discussion----------[Messenger] Doctrine Connection find and findAll now correctly decode headers| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#31916| License       | MIT| Doc PR        | N/AThe Doctrine transport `Connection` class methods `find` and `findAll` did not JSON-decode the headers of the envelope after retrieving it from Doctrine. The `get` method, however, did this correctly.I added two tests to verify the results of `find` and `findAll` and then added the JSON-decoding to the `Connection` class. I moved the JSON-decoding to a separate method to avoid duplicate code.Commits-------3aec2ac [Messenger] Doctrine Connection find and findAll now correctly decode headers

Copy link

MemberAuthor