Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI][5.0] Fix suspicious test#31945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| /** | ||
| * @group legacy | ||
| */ | ||
| publicfunctiontestConfigurationWithoutRootNode():void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this cannot happen anymore with Config 5.0, in the#31678 the deps are updated .. as such i assumed we dont need this test anymore.
| /** | ||
| * @author Roland Franssen <franssen.roland@gmail.com> | ||
| */ | ||
| class TreeWithoutRootNodeExceptionextends \RuntimeException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
maybe we forgot to mark this@internal in 4.x ... 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let's add it#31944 :)
nicolas-grekas commentedJun 8, 2019
Thank you@ro0NL. |
This PR was merged into the 5.0-dev branch.Discussion----------[DI][5.0] Fix suspicious test| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Cleanup of#31944 for 5.0Commits-------98c25dd [DI][5.0] Fix suspicious test
Cleanup of#31944 for 5.0