Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] highlight suspicious tests#31942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| { | ||
| publicfunctiongetConfigTreeBuilder() | ||
| { | ||
| thrownew \Exception(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the test ensures we dont require a node to be present, if the user didnt configure anything. However the side effect is the config tree isnt even initialized ... so it doesnt matter much what happens here.
I'd keep this tree for the purpose of clarity, in the sense we don't expect anInvalidConfigException duenodes being required.
| { | ||
| publicfunctiongetConfigTreeBuilder() | ||
| { | ||
| thrownew \Exception(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
up for a PR?
nicolas-grekas commentedJun 7, 2019
This PR was merged into the 4.2 branch.Discussion----------[DI] Fix suspicious test| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#31942| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->cc@nicolas-grekasCommits-------25b961a [DI] Fix suspicious test
Why doesn't this break something?
Related to#27710 I think
/cc@xabbuh@ro0NL if you have any idea why :)