NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Allow custom transports for mailer component#31935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ajgarlag wants to merge2 commits intosymfony:4.4fromajgarlag:feature/mailer-custom-transport

Closed

Allow custom transports for mailer component#31935

ajgarlag wants to merge2 commits intosymfony:4.4fromajgarlag:feature/mailer-custom-transport

Conversation

Copy link

Contributor

ajgarlag commentedJun 7, 2019

Q	A
Branch?	4.4
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#31385
License	MIT
Doc PR	TBD symfony/symfony-docs#...

This PR allows to define a custom transport for mailer component.
To enable it, set theframework.mailer.dsn key tonull and the newframework.mailer.transport_id key to the transport service id you want to inject into the default mailer instance.

Allow custom transports for mailer component

acfed82

carsonbot added Status: Needs Review Feature labels

Jun 7, 2019

Copy link

Contributor

kevin-verschaeve commentedJun 7, 2019

I have done the same a few hours ago in#31931 :/

(but not really the same way)

Define the giventransport_id as the default mailer transport

ce67819

Copy link

ContributorAuthor

ajgarlag commentedJun 7, 2019

@kevin-verschaeve Sorry, did not see your PR. I'll review it.

nicolas-grekas added this to thenext milestone

Jun 7, 2019

Koc mentioned this pull request

Jun 7, 2019

[Mailer] Extract transport factory and allow create custom transports#31946

Merged

3 tasks

Copy link

Member

fabpot commentedJul 8, 2019

Thanks for the PR. I think I prefer something that allows third party to implement a mailer provider with the same "feel" as built-in ones (with a proper DSN). That's what#31946 implements.

fabpot closed this

Jul 8, 2019

fabpot added a commit that referenced this pull request

Jul 17, 2019

feature#31946[Mailer] Extract transport factory and allow create cu…

e5ad989

…stom transports (Koc)This PR was merged into the 4.4 branch.Discussion----------[Mailer] Extract transport factory and allow create custom transports| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes, failure unrelated (master hasn't this PR)| Fixed tickets |#31385,#32523| License       | MIT| Doc PR        | TBDAlternative approach to allow create custom transports and register DSN for it. Replaces#31931,#31935 . Similar to already existent TansportFactory from Messenger.TODO: - [x] Update changelog - [x] Add more tests for factories - [x] Add test for configuration + DI extensionCommits-------5b9cded Add transport factories (closes#31385,closes#32523)