Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer][FrameworkBundle] Add a way to use a custom transport#31931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@kevin-verschaeve
Copy link
Contributor

@kevin-verschaevekevin-verschaeve commentedJun 7, 2019•
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?todo
Fixed tickets#31385
LicenseMIT
Doc PRtodo

Add a "custom" provider, to allow using a custom transport class.

MAILER_DSN=http://user:pass@custom

canfix#31385

@kevin-verschaevekevin-verschaeve changed the title[Mailer] Add a way to use a custom transport[Mailer][FrameworkBundle] Add a way to use a custom transportJun 7, 2019
@nicolas-grekasnicolas-grekas added this to thenext milestoneJun 7, 2019
@nicolas-grekasnicolas-grekas changed the base branch frommaster to4.4June 7, 2019 13:51
@nicolas-grekas
Copy link
Member

please rebase for 4.4

@kevin-verschaeve
Copy link
ContributorAuthor

Branch changed to 4.4

@kevin-verschaevekevin-verschaeveforce-pushed themailer/custom-transport branch 2 times, most recently fromd4b1405 to2eff65dCompareJune 11, 2019 08:26
@fabpot
Copy link
Member

This implementation would only allow one custom DSN, but we want third-parties to be able to provide their own DSN, so we need multiple possible custom DSNs.

@fabpotfabpot closed thisJun 29, 2019
fabpot added a commit that referenced this pull requestJul 17, 2019
…stom transports (Koc)This PR was merged into the 4.4 branch.Discussion----------[Mailer] Extract transport factory and allow create custom transports| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes, failure unrelated (master hasn't this PR)| Fixed tickets |#31385,#32523| License       | MIT| Doc PR        | TBDAlternative approach to allow create custom transports and register DSN for it. Replaces#31931,#31935 . Similar to already existent TansportFactory from Messenger.TODO: - [x] Update changelog - [x] Add more tests for factories - [x] Add test for configuration + DI extensionCommits-------5b9cded Add transport factories (closes#31385,closes#32523)
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@ajgarlagajgarlagajgarlag left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

[Mailer] Allow create custom transports and register DSN for it

6 participants

@kevin-verschaeve@nicolas-grekas@fabpot@ajgarlag@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp