Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] avoid service id conflicts with Swiftmailer#31928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJun 7, 2019
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31906 |
| License | MIT |
| Doc PR |
| $loader->load('mailer.xml'); | ||
| $container->getDefinition('mailer.transport')->setArgument(0,$config['dsn']); | ||
| $container->getDefinition('mailer.default_transport')->setArgument(0,$config['dsn']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
mailer.transport would conflict withhttps://github.com/symfony/monolog-bundle/blob/master/DependencyInjection/Compiler/AddSwiftMailerTransportPass.php#L40 if$mailerId ismailer
xabbuh commentedJun 7, 2019
alternatively, we can update the compiler pass in MonologBundle and check the transport class there |
| <serviceid="Symfony\Component\Mailer\MailerInterface"alias="mailer.mailer" /> | ||
| <serviceid="mailer.transport"class="Symfony\Component\Mailer\Transport\TransportInterface"> | ||
| <serviceid="mailer.default_transport"class="Symfony\Component\Mailer\Transport\TransportInterface"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
changing the id here might cause trouble for developers who have already updated and are using this id
nicolas-grekas commentedJun 7, 2019
Thank you@xabbuh. |
…ler (xabbuh)This PR was merged into the 4.3 branch.Discussion----------[FrameworkBundle] avoid service id conflicts with Swiftmailer| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31906| License | MIT| Doc PR |Commits-------5ce0ede avoid service id conflicts with Swiftmailer