NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Fix DataUriNormalizer docblock & composer suggest section#31922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:fix/serializer/data-uri-docblock

Jun 7, 2019

Merged

[Serializer] Fix DataUriNormalizer docblock & composer suggest section#31922

nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:fix/serializer/data-uri-docblock

Jun 7, 2019

Conversation

Copy link

Contributor

ogizanagi commentedJun 7, 2019

Q	A
Branch?	3.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes/no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

See

symfony/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php

Lines 135 to 139 in9691519

	if ($this->mimeTypeGuesser &&$mimeType =$this->mimeTypeGuesser->guess($object->getPathname())) {
	return$mimeType;
	}

	return'application/octet-stream';

[Serializer] Fix DataUriNormalizer docblock & composer suggest section

51b6bd8

ogizanagi requested a review fromdunglas as acode owner

June 7, 2019 08:56

carsonbot added Status: Needs Review Serializer Deprecation labels

Jun 7, 2019

ogizanagi mentioned this pull request

Jun 7, 2019

[Serializer] Fix DataUriNormalizer deprecation (MIME type guesser is optional)#31923

Merged

nicolas-grekas removed the Deprecation label

Jun 7, 2019

Copy link

Member

nicolas-grekas commentedJun 7, 2019

Thank you@ogizanagi.

nicolas-grekas merged commit51b6bd8 intosymfony:3.4

Jun 7, 2019

nicolas-grekas added a commit that referenced this pull request

Jun 7, 2019

minor#31922[Serializer] Fix DataUriNormalizer docblock & composer s…

50b3ba9

…uggest section (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[Serializer] Fix DataUriNormalizer docblock & composer suggest section| Q             | A| ------------- | ---| Branch?       | 3.4  <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/ASeehttps://github.com/symfony/symfony/blob/9691519ca46511005bc701ca93c2973923952034/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php#L135-L139Commits-------51b6bd8 [Serializer] Fix DataUriNormalizer docblock & composer suggest section

ogizanagi deleted the fix/serializer/data-uri-docblock branch

June 7, 2019 14:26