Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Add missing runtime check for ext redis version#31872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr commentedJun 5, 2019
Build failure is unrelated. |
| private$autoSetup; | ||
| private$couldHavePendingMessages =true; | ||
| publicfunction__construct(array$configuration,array$connectionCredentials = [],array$redisOptions = [],\Redis$redis =null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
unrelated, but we missed making this class compatible with other kind of redis instances: RedisArray, RedisCluser, RedisProxy and RedisClusterProxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
are they compatible with redis streams ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think so, because in the end this is just a key.https://redis.io/topics/streams-intro also mentions clusters. But I didn't try, so maybe not. Yet the hardcoded signature would be a blocker for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I will give it a try and drop the typehint in favor of a check anyways.
fabpot commentedJun 5, 2019
Thank you@chalasr. |
…n (chalasr)This PR was merged into the 4.3 branch.Discussion----------[Messenger] Add missing runtime check for ext redis version| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31791| License | MIT| Doc PR | n/aLower versions lead to segmentation faults.Commits-------07603da [Messenger] Add runtime check for ext redis version
This PR was merged into the 4.3 branch.Discussion----------Redis 4.3 is requiredSeesymfony/symfony#31872But also the conversation onsymfony/messenger@47d2b91So, I'm not actually sure if that commit is correct and the docs should be updated, or if that commit is wrong. Opening this up to at least have some placeholder to figure that out.Commits-------c76afd3 Redis 4.3 is required
Lower versions lead to segmentation faults.