Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] work around PHP 7.3 bug related to json_encode()#31861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
LordNouda left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi Nicolas,
I checked this according to@weaverryan 's great tutorial oncontributing back to Symfony over at SymfonyCasts. I could reproduce the error with PHP@7.3.6. With PHP@7.2.19 it does not occur.
I hope this helps.
I'm relatively new to Symfony and this would be my first contribution.
Cheers, Manuel
fabpot commentedJun 5, 2019
Thank you@nicolas-grekas. |
…e() (nicolas-grekas)This PR was merged into the 4.3 branch.Discussion----------[HttpClient] work around PHP 7.3 bug related to json_encode()| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This is the remaining of ##31860 for upper branches.Commits-------42904e3 [HttpClient] work around PHP 7.3 bug related to json_encode()
…nicolas-grekas)This PR was merged into the 4.3 branch.Discussion----------[HttpClient] revert bad logic around JSON_THROW_ON_ERROR| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Same as#31869, reverts#31861Commits-------846116e [HttpClient] revert bad logic around JSON_THROW_ON_ERROR
This is the remaining of ##31860 for upper branches.