Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Add check for Konsole/Yakuake to disable hyperlinks#31849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please link to a Konsole issue so we can track when they fix this?
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedJun 4, 2019
Oh, please also patch VarDumper, it has a similar check. |
belinde commentedJun 4, 2019
I'm on it. I've also noted that there was a test for TERMINAL_EMULATOR=JetBrains-JediTerm: should I add a test just for Konsole? And what should I do, just add another commit to the PR or I must close it and do another one with the two commits squashed? |
nicolas-grekas commentedJun 4, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
No tests is OK to me, this wouldn't make much sense. |
belinde commentedJun 4, 2019
Opened bug report to Konsole:https://bugs.kde.org/show_bug.cgi?id=408288 |
nicolas-grekas left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks
For reference, this is a description of the feature for terminals:
https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
And I just discovered this gist contains a link to an existing Konsole issue:
https://bugs.kde.org/show_bug.cgi?id=379294
(but your issue is different: it's about degrading gracefully - not necessarily about supporting links)
fabpot commentedJun 5, 2019
Thank you@belinde. |
…nks (belinde)This PR was squashed before being merged into the 4.3 branch (closes#31849).Discussion----------[Console] Add check for Konsole/Yakuake to disable hyperlinks| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31809| License | MIT| Doc PR |Added check for environment variable set by Konsole and other relateds terminal emulators.A ticket has been opened to Konsole team to support this feature someday:https://bugs.kde.org/show_bug.cgi?id=408288Commits-------14b27b7 [Console] Add check for Konsole/Yakuake to disable hyperlinks
This PR was merged into the 4.4 branch.Discussion----------[Console] Re-enable hyperlinks in Konsole/Yakuake| Q | A| ------------- | ---| Branch? | 4.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fix#31809 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MITHyperlinks feature was broken in KDE's Konsole/Yakuake (#31809) and thus disabled by#31849.But the feature has been recently [implemented](https://invent.kde.org/utilities/konsole/-/merge_requests/138), and is about to be released in KDE 20.12 on December 10th 2020, see [release notes](https://community.kde.org/Releases/20.12_Release_Notes#Konsole).Tested in RC version and seems to be working fine. The feature is disabled by default (as per security concerns), but even when disabled, it just gracefully don't show the links.Commits-------728edf3 [Console] Enable hyperlinks in Konsole/Yakuake
Uh oh!
There was an error while loading.Please reload this page.
Added check for environment variable set by Konsole and other relateds terminal emulators.
A ticket has been opened to Konsole team to support this feature someday:https://bugs.kde.org/show_bug.cgi?id=408288