Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] don't break BC badly#31845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJun 4, 2019
The issue I see here is that consumers of the interface now cannot rely on the method being present which makes it more or less useless. |
stof commentedJun 4, 2019
I think I actually prefer#31842. We should not use the caret operator when depending on an experimental package, as this experimental package does not guarantee BC yet (and so relying on the semver BC rules is a wrong assumption). |
fabpot commentedJun 4, 2019
What about considering#31850 instead? |
nicolas-grekas commentedJun 5, 2019
Closing in favor of#31850 |
This PR was merged into the 4.3 branch.Discussion----------[HttpClient] add $response->cancel()| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#11668An alternative to#31845 and#31842.Same as#31831 but considered as a bug fix (at the Contracts level), thus for 4.3.I think we're early enough since 4.3/1.1 to do it.That will save us some headaches in the short term.Commits-------c402418 [HttpClient] add $response->cancel()
Follows#31831, replaces#31842, as I'd prefer not sticking to a specific minor version - that'd be bad for transitivity of deps IMHO.
/cc@xabbuh@fabpot