Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] prevent installation of contracts 1.2#31842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedJun 4, 2019
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
Member
nicolas-grekas commentedJun 4, 2019
Hey, no :) Why? |
MemberAuthor
xabbuh commentedJun 4, 2019
In 4.3 we do not implement the |
MemberAuthor
xabbuh commentedJun 4, 2019
Member
nicolas-grekas commentedJun 4, 2019
Or we could remove the method from the interface and turn it into an |
This was referencedJun 4, 2019
MemberAuthor
xabbuh commentedJun 5, 2019
closing in favour of#31850 |
fabpot added a commit that referenced this pull requestJun 5, 2019
This PR was merged into the 4.3 branch.Discussion----------[HttpClient] add $response->cancel()| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#11668An alternative to#31845 and#31842.Same as#31831 but considered as a bug fix (at the Contracts level), thus for 4.3.I think we're early enough since 4.3/1.1 to do it.That will save us some headaches in the short term.Commits-------c402418 [HttpClient] add $response->cancel()
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.