NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Lock] prune PdoStorage table on each save according to gcProbability#31804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

pableu wants to merge2 commits intosymfony:masterfrompableu:master

Closed

[Lock] prune PdoStorage table on each save according to gcProbability#31804

pableu wants to merge2 commits intosymfony:masterfrompableu:master

Conversation

Copy link

Contributor

pableu commentedJun 3, 2019

Q	A
Branch?	4.2
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT

I expected the\Symfony\Component\Lock\Store\PdoStore::prune method to be called according togcProbability every time I interact with a lock. But\Symfony\Component\Lock\Store\PdoStore::save returns early on success. As I see it, this means that expired locks are pruned much less often than specified bygcProbability.

This PR fixes that by calling prune before the early return.

I'm not so sure if checking the probabilityinside theprune method is a good solution. Maybe it would be nicer to have a separate function (randomPrune).