Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Translation] Fixed case sensitivity of lint:xliff command#31786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.2fromjaviereguiluz:fix_xliff_lint
Jun 3, 2019

Conversation

@javiereguiluz
Copy link
Member

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR(not needed)

I was checking some errors oflint:xliff (https://travis-ci.org/EasyCorp/EasyAdminBundle/jobs/540053551#L657) and saw this:

ERROR  in src/Resources/translations/EasyAdminBundle.sr_RS.xlf * There is a mismatch between the language included in the file name ("EasyAdminBundle.sr_RS.xlf") and the "sr-rs" value used in the "target-language" attribute of the file.ERROR  in src/Resources/translations/EasyAdminBundle.zh_CN.xlf * There is a mismatch between the language included in the file name ("EasyAdminBundle.zh_CN.xlf") and the "zh-cn" value used in the "target-language" attribute of the file.

This was suspicious, so I checked the XLIFF standard and it says (http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#target-language):

target-language:  Unlike the other XLIFF attributes, the values are not case-sensitive.

So, it's valid thatzh-cn is the target language andzh-CN is the file extension. This PR fixes that.

@nicolas-grekas
Copy link
Member

Thank you@javiereguiluz.

@nicolas-grekasnicolas-grekas merged commitec690b2 intosymfony:4.2Jun 3, 2019
nicolas-grekas added a commit that referenced this pull requestJun 3, 2019
… (javiereguiluz)This PR was squashed before being merged into the 4.2 branch (closes#31786).Discussion----------[Translation] Fixed case sensitivity of lint:xliff command| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | -| License       | MIT| Doc PR        | (not needed)I was checking some errors of `lint:xliff` (https://travis-ci.org/EasyCorp/EasyAdminBundle/jobs/540053551#L657) and saw this:```ERROR  in src/Resources/translations/EasyAdminBundle.sr_RS.xlf * There is a mismatch between the language included in the file name ("EasyAdminBundle.sr_RS.xlf") and the "sr-rs" value used in the "target-language" attribute of the file.ERROR  in src/Resources/translations/EasyAdminBundle.zh_CN.xlf * There is a mismatch between the language included in the file name ("EasyAdminBundle.zh_CN.xlf") and the "zh-cn" value used in the "target-language" attribute of the file.```This was suspicious, so I checked the XLIFF standard and it says (http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#target-language):```target-language:  Unlike the other XLIFF attributes, the values are not case-sensitive.```So, it's valid that `zh-cn` is the target language and `zh-CN` is the file extension. This PR fixes that.Commits-------ec690b2 [Translation] Fixed case sensitivity of lint:xliff command
@fabpotfabpot mentioned this pull requestJun 6, 2019
@fabpotfabpot mentioned this pull requestJun 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@javiereguiluz@nicolas-grekas@fabpot@yceruto@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp