NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Form] do not iterate twice on the extended types#31779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:masterfromTobion:simplify-form-code

Jun 1, 2019

Merged

[Form] do not iterate twice on the extended types#31779

nicolas-grekas merged 1 commit intosymfony:masterfromTobion:simplify-form-code

Jun 1, 2019

Conversation

Copy link

Contributor

Tobion commentedMay 31, 2019

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#...
License	MIT
Doc PR

Simplification of#31703

[Form] do not iterate twice on the extended types

75179d3

Tobion requested a review fromxabbuh as acode owner

May 31, 2019 22:16

carsonbot added Status: Needs Review Form labels

May 31, 2019

yceruto approved these changes

May 31, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

May 31, 2019

vudaltsov approved these changes

Jun 1, 2019

View reviewed changes

nicolas-grekas added this to the5.0 milestone

Jun 1, 2019

Copy link

Member

nicolas-grekas commentedJun 1, 2019

Thank you@Tobion.

nicolas-grekas merged commit75179d3 intosymfony:master

Jun 1, 2019

nicolas-grekas added a commit that referenced this pull request

Jun 1, 2019

minor#31779[Form] do not iterate twice on the extended types (Tobion)

371dfc7

This PR was merged into the 5.0-dev branch.Discussion----------[Form] do not iterate twice on the extended types| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |Simplification of#31703Commits-------75179d3 [Form] do not iterate twice on the extended types

Tobion deleted the simplify-form-code branch

June 1, 2019 16:42