Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DomCrawler] Fix type error with null Form::$currentUri#31757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
chalasr commentedMay 30, 2019
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31644 |
| License | MIT |
| Doc PR | n/a |
chalasr commentedMay 30, 2019
| * @param string $currentUri The URI of the page where the form is embedded | ||
| * @param string $method The method to use for the link (if null, it defaults to the method defined by the form) | ||
| * @param string $baseHref The URI of the <base> used for relative links, but not for empty action | ||
| * |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I did not fix the docblock as there are plenty of missing|null across the component codebase, should be done globally on 3.4.
derrabus approved these changesMay 31, 2019
Member
nicolas-grekas commentedMay 31, 2019
Thank you@chalasr. |
nicolas-grekas added a commit that referenced this pull requestMay 31, 2019
…halasr)This PR was merged into the 4.2 branch.Discussion----------[DomCrawler] Fix type error with null Form::$currentUri| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31644| License | MIT| Doc PR | n/aCommits-------e48d5d0 [DomCrawler] Fix type error with null Form::$currentUri
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.