Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DoctrineBridge][Validator] do not enable validator auto mapping by default#31749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMay 30, 2019
Contributor
phansys commentedMay 30, 2019
I confirm this PR solves the issue reported at#31743. |
phansys approved these changesMay 30, 2019
chalasr approved these changesMay 30, 2019
pamil approved these changesMay 31, 2019
Contributor
pamil left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tested on Sylius, fixes the issue, thanks! 🎉
Member
nicolas-grekas commentedMay 31, 2019
Thank you@xabbuh. |
nicolas-grekas added a commit that referenced this pull requestMay 31, 2019
…apping by default (xabbuh)This PR was merged into the 4.3 branch.Discussion----------[DoctrineBridge][Validator] do not enable validator auto mapping by default| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | part of#31715,#31752| License | MIT| Doc PR |Commits-------a3555fc do not enable validator auto mapping by default
Merged
This was referencedJun 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.