Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Inject RoutableMessageBus instead of bus locator#31748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromchalasr:inject-routable-messagebus
May 31, 2019

Conversation

@chalasr
Copy link
Member

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#31741
LicenseMIT
Doc PRn/a

@chalasr
Copy link
MemberAuthor

Fabbot wants me to splitnew class { } into multiple lines so I'm going to ignore him :)

@chalasrchalasrforce-pushed theinject-routable-messagebus branch 2 times, most recently from853449f todc95fa5CompareMay 30, 2019 20:16
@chalasrchalasrforce-pushed theinject-routable-messagebus branch 2 times, most recently from53183c0 to8b0342aCompareMay 30, 2019 22:53
@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit91817e4 intosymfony:4.3May 31, 2019
fabpot added a commit that referenced this pull requestMay 31, 2019
…or (chalasr)This PR was merged into the 4.3 branch.Discussion----------[Messenger] Inject RoutableMessageBus instead of bus locator| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#31741| License       | MIT| Doc PR        | n/aCommits-------91817e4 [Messenger] Inject RoutableMessageBus instead of bus locator
@chalasrchalasr deleted the inject-routable-messagebus branchMay 31, 2019 13:03
fabpot added a commit that referenced this pull requestJun 1, 2019
…MessagesCommand's constructor (chalasr)This PR was merged into the 4.4 branch.Discussion----------[Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand's constructor| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aContinuation of#31748Commits-------1409338 [Messenger] Deprecate passing a bus locator to ConsumeMessagesCommand constructor
@fabpotfabpot mentioned this pull requestJun 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@weaverryanweaverryanweaverryan left review comments

@fabpotfabpotfabpot approved these changes

@srozesrozeAwaiting requested review from sroze

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@fabpot@weaverryan@Tobion@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp