Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Add missing BC layer for deprecated ControllerNameParser injections#31739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@chalasr
Copy link
Member

QA
Branch?4.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

Allows removing theControllerNameParser class and correspondingcontroller_name_converter service in 5.0.
Should have been done in 4.1, better late than never.

@chalasr
Copy link
MemberAuthor

Fabbot failure is a false positive.

@nicolas-grekasnicolas-grekas added this to thenext milestoneMay 30, 2019
@chalasrchalasrforce-pushed thecontroller-name-parser-bclayer branch 4 times, most recently from83f02cd tocc3cc48CompareMay 30, 2019 15:46
@Simperfit
Copy link
Contributor

Thanks@chalasr !

chalasr reacted with heart emoji

@Simperfit
Copy link
Contributor

Status: Needs review

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks, just minor comments

@chalasrchalasrforce-pushed thecontroller-name-parser-bclayer branch 3 times, most recently fromc435c45 toa00eb63CompareMay 31, 2019 09:03
@chalasr
Copy link
MemberAuthor

Thanks for the review, comments addressed

@chalasrchalasrforce-pushed thecontroller-name-parser-bclayer branch 5 times, most recently frome7ac670 tofac9377CompareMay 31, 2019 18:45
@chalasrchalasrforce-pushed thecontroller-name-parser-bclayer branch 6 times, most recently from8d029ce to5bf0fcdCompareMay 31, 2019 22:38
@chalasrchalasrforce-pushed thecontroller-name-parser-bclayer branch 3 times, most recently frome9e8e9c tobdaf15dCompareJune 3, 2019 13:20
@chalasrchalasrforce-pushed thecontroller-name-parser-bclayer branch frombdaf15d to1f37275CompareJune 3, 2019 13:37
@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit1f37275 intosymfony:4.4Jun 4, 2019
fabpot added a commit that referenced this pull requestJun 4, 2019
…ControllerNameParser injections (chalasr)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle] Add missing BC layer for deprecated ControllerNameParser injections| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aAllows removing the `ControllerNameParser` class and corresponding `controller_name_converter` service in 5.0.Should have been done in 4.1, better late than never.Commits-------1f37275 [FrameworkBundle] Add missing BC layer for deprecated ControllerNameParser injections
@chalasrchalasr deleted the controller-name-parser-bclayer branchJune 4, 2019 10:33
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@derrabusderrabusderrabus requested changes

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@TobionTobionTobion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@chalasr@Simperfit@fabpot@nicolas-grekas@Tobion@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp