Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] More accurate grouping#31730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8193095 to38f3621Comparejmsche commentedMay 30, 2019
Hi there, it seems better to me :) FYI using Symfony 4.3.0-beta1 (without the Twig fixes in Pre-patch: Post-patch: |
a2a7612 to0febb03Compare116907f tod67f50cCompare| { | ||
| privateconstPATH_TYPE_VENDOR ='path_type_vendor'; | ||
| privateconstPATH_TYPE_SELF ='path_type_internal'; | ||
| privateconstPATH_TYPE_UNDETERMINED ='path_type_undetermined'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I could have used an exception instead of 3-value return, but it did not feel "exceptional" enough. This is going to happen whenever a deprecation comes from the cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hello PHP 5.5, we cannot use these consts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed in0c9b3c0
fabpot commentedJun 26, 2019
Thank you@greg0ire. |
This PR was squashed before being merged into the 4.3 branch (closes#31730).Discussion----------[PhpUnitBridge] More accurate grouping| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aSometimes, you cannot easily know if code was written by a vendor ordirectly in the application, for instance if the code comes from a filein the cache. In that case, it is better not to classify the deprecationas direct or indirect.@jmsche please test this on your application when you can, I think you might be having that issue.Commits-------d9f0ba3 [PhpUnitBridge] More accurate grouping
nicolas-grekas commentedJun 26, 2019
This breaks the CI and I cannot reproduce locally (yet), for deps=low/high jobs: Not a bug, just a side-effect of the CI. |
nicolas-grekas commentedJun 26, 2019
Reverted in4814fd3 |
* 4.3: Revert "bug#31730 [PhpUnitBridge] More accurate grouping (greg0ire)"
* 4.4: Revert "bug#31730 [PhpUnitBridge] More accurate grouping (greg0ire)"
…eg0ire)""This reverts commit4814fd3.
* 4.3: Reject phpunit-bridge v5 for now Revert "Revert "bug#31730 [PhpUnitBridge] More accurate grouping (greg0ire)""
* 4.4: Reject phpunit-bridge v5 for now Revert "Revert "bug#31730 [PhpUnitBridge] More accurate grouping (greg0ire)""
nicolas-grekas commentedJun 26, 2019
Revert reverted because actually it's not the issue, I'm loosing my mind on because I cannot reproduce locally :) |
Sometimes, you cannot easily know if code was written by a vendor or
directly in the application, for instance if the code comes from a file
in the cache. In that case, it is better not to classify the deprecation
as direct or indirect.
@jmsche please test this on your application when you can, I think you might be having that issue.