Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PHPUnitBridge] Use a more appropriate group when deprecating mode#31721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:4.3fromgreg0ire:use-direct-group-for-phpunit-mode-deprecationMay 30, 2019
Merged
[PHPUnitBridge] Use a more appropriate group when deprecating mode#31721
nicolas-grekas merged 1 commit intosymfony:4.3fromgreg0ire:use-direct-group-for-phpunit-mode-deprecationMay 30, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The deprecation comes from a vendor: the phpunit bridge itself, so it'seither the direct or the indirect group. And since only the end user issupposed to set the group, then this is supposed to be a directdeprecation.
nicolas-grekas approved these changesMay 30, 2019
derrabus approved these changesMay 30, 2019
Member
nicolas-grekas commentedMay 30, 2019
Thank you@greg0ire. |
nicolas-grekas added a commit that referenced this pull requestMay 30, 2019
…ing mode (greg0ire)This PR was merged into the 4.3 branch.Discussion----------[PHPUnitBridge] Use a more appropriate group when deprecating mode| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aThe deprecation comes from a vendor: the phpunit bridge itself, so it'seither the direct or the indirect group. And since only the end user issupposed to set the group, then this is supposed to be a directdeprecation.Commits-------3a88f11 Use a more appropriate group when deprecating mode
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.