NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DX][Messenger] Improve error message when routing to an invalid transport#31710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4fromKoc:better-error-on-invalid-routing

Sep 28, 2019

Merged

[DX][Messenger] Improve error message when routing to an invalid transport#31710

fabpot merged 1 commit intosymfony:4.4fromKoc:better-error-on-invalid-routing

Sep 28, 2019

Conversation

Copy link

Contributor

Koc commentedMay 29, 2019•
edited
Loading

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#31613
License	MIT
Doc PR	-

carsonbot added Status: Needs Review DX

DX = Developer eXperience (anything that improves the experience of using Symfony)

Messenger labels

May 29, 2019

chalasr added this to thenext milestone

May 29, 2019

nicolas-grekas reviewed

May 30, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php OutdatedShow resolvedHide resolved

Koc force-pushed thebetter-error-on-invalid-routing branch fromc0e8cd5 to7e50affCompare

June 2, 2019 20:29

Copy link

ContributorAuthor

Koc commentedJun 2, 2019

BTW, does anybody knows why Travis failed with error

  [ErrorException]           Undefined index: master

? Is this problem caused by Symfony Flex or what?

Copy link

Contributor

Simperfit commentedJun 3, 2019

@Koc I think you just need to repush

Koc force-pushed thebetter-error-on-invalid-routing branch 2 times, most recently from470e6d5 to464f326Compare

June 3, 2019 19:16

Koc force-pushed thebetter-error-on-invalid-routing branch from464f326 to94a404fCompare

June 18, 2019 16:28

Copy link

Contributor

sroze commentedJul 2, 2019

@Koc any chance you can rebase on4.4?

Copy link

Contributor

Simperfit commentedJul 14, 2019

@Koc could you rebase please ?

Koc force-pushed thebetter-error-on-invalid-routing branch from040aa8c to0e78098Compare

July 15, 2019 01:10

Copy link

ContributorAuthor

Koc commentedJul 15, 2019

Rebase was done, now trying to fix tests

Copy link

Member

nicolas-grekas commentedSep 27, 2019

(rebase needed)

Koc force-pushed thebetter-error-on-invalid-routing branch frombdc8896 toff33f61Compare

September 27, 2019 21:50

[Messenger] Improve error message when routing to an invalid transport (

7909092

closessymfony#31613)

Koc force-pushed thebetter-error-on-invalid-routing branch from9342d65 to7909092Compare

September 27, 2019 22:24

Copy link

ContributorAuthor

Koc commentedSep 27, 2019

rebased, tests are green

fabpot approved these changes

Sep 28, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Sep 28, 2019

Copy link

Member

fabpot commentedSep 28, 2019

Thank you@Koc.

fabpot added a commit that referenced this pull request

Sep 28, 2019

minor#31710[DX][Messenger] Improve error message when routing to an…

ae61ae5

… invalid transport (Koc)This PR was merged into the 4.4 branch.Discussion----------[DX][Messenger] Improve error message when routing to an invalid transport| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#31613| License       | MIT| Doc PR        | -Commits-------7909092 [Messenger] Improve error message when routing to an invalid transport (closes#31613)