NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] fix deprecation of fragments by using FQCN#31708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Simperfit wants to merge1 commit intosymfony:4.3fromSimperfit:fix-fragment-template-with-fqcn-call

Closed

[FrameworkBundle] fix deprecation of fragments by using FQCN#31708

Simperfit wants to merge1 commit intosymfony:4.3fromSimperfit:fix-fragment-template-with-fqcn-call

Conversation

Copy link

Contributor

Simperfit commentedMay 29, 2019

Q	A
Branch?	4.3
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	non
License	MIT
Doc PR	non

This fixes the error I got inhttps://travis-ci.org/symfony/symfony/jobs/538890475 and I don't understand why it doesn't fail anywhere else.

carsonbot added Status: Needs Review FrameworkBundle labels

May 29, 2019

nicolas-grekas added this to the4.3 milestone

May 29, 2019

Copy link

Member

nicolas-grekas commentedMay 29, 2019

We're missing something, this breaks tests on 4.3.
Anyone with a clue?

[FrameworkBundle] fix deprecation of fragments by using FQCN

80e45c1

Simperfit force-pushed thefix-fragment-template-with-fqcn-call branch from34bab1b to80e45c1Compare

May 29, 2019 21:24

Copy link

ContributorAuthor

Simperfit commentedMay 29, 2019

test fixed

Copy link

Member

chalasr commentedMay 29, 2019

I don't understand why it doesn't fail anywhere else.

Because theResolveControllerNameSubscriber class that you are removing in#31702 was preventing the deprecation from being triggered as it converts controller names that use the deprecated notation to a one that use a valid notation (class::method). The test case should have been broken way before your PRs.

This means that we also miss a deprecation notice inResolveControllerNameSubscriber since 4.1 which we may want to add in 4.4 to make the BC layer complete.