Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Remove support for the bundle:controller:action notation#31702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone
LicenseMIT
Doc PRnone no mention in the docs

This remove the ResolveControllerNameSubscriber since it is deprecated, it ease the cleaning of HttpKernel see#31672 (comment)

@nicolas-grekas
Copy link
Member

Can you please have a look at tests?

@SimperfitSimperfitforce-pushed thefeature/remove-the-deprecated-ResolveControllerName-subscriber branch fromc8e08bd to295766cCompareMay 29, 2019 18:30
@Simperfit
Copy link
ContributorAuthor

@nicolas-grekas done

@Tobion
Copy link
Contributor

There are test failures that should be fixed with#31713

@SimperfitSimperfitforce-pushed thefeature/remove-the-deprecated-ResolveControllerName-subscriber branch 2 times, most recently froma12b288 toa6a0df2CompareMay 30, 2019 21:39
@chalasrchalasr changed the title[FrameworkBundle] remove the deprecated ResolveControllerNameSubscriber[FrameworkBundle] Remove support for the bundle:controller:action and service:method notationsMay 30, 2019
@chalasrchalasr changed the title[FrameworkBundle] Remove support for the bundle:controller:action and service:method notations[FrameworkBundle] Remove support for the bundle:controller:action notationMay 30, 2019
@SimperfitSimperfitforce-pushed thefeature/remove-the-deprecated-ResolveControllerName-subscriber branch 2 times, most recently fromc465675 toc4ed065CompareMay 31, 2019 08:32
@Simperfit
Copy link
ContributorAuthor

update cc@Tobion@chalasr

@Tobion
Copy link
Contributor

LGTM, but we should probably wait on#31739 and then rebase.

@fabpot
Copy link
Member

#31739 has been merged now.

@SimperfitSimperfitforce-pushed thefeature/remove-the-deprecated-ResolveControllerName-subscriber branch 3 times, most recently frome13e4d5 to4ba93f2CompareJune 4, 2019 07:29
@Simperfit
Copy link
ContributorAuthor

@fabpot PR rebased with master

@SimperfitSimperfitforce-pushed thefeature/remove-the-deprecated-ResolveControllerName-subscriber branch from4ba93f2 to4574197CompareJune 4, 2019 10:21
@Simperfit
Copy link
ContributorAuthor

Tests and comments fixed.

@fabpot
Copy link
Member

Tests are broken. Can you have a look@Simperfit?

@SimperfitSimperfitforce-pushed thefeature/remove-the-deprecated-ResolveControllerName-subscriber branch from4574197 to29e3c2fCompareJune 4, 2019 10:31
@Simperfit
Copy link
ContributorAuthor

Tests are fixed now@fabpot.

@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit29e3c2f intosymfony:masterJun 4, 2019
fabpot added a commit that referenced this pull requestJun 4, 2019
…er:action notation (Simperfit)This PR was merged into the 5.0-dev branch.Discussion----------[FrameworkBundle] Remove support for the bundle:controller:action notation| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | none <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |none no mention in the docs <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->This remove the ResolveControllerNameSubscriber  since it is deprecated, it ease the cleaning of HttpKernel see#31672 (comment)Commits-------29e3c2f [FrameworkBundle] remove deprecater controller a:b:c notation
@SimperfitSimperfit deleted the feature/remove-the-deprecated-ResolveControllerName-subscriber branchJune 4, 2019 11:57
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJun 6, 2019
…der` service (yceruto)This PR was merged into the 5.0-dev branch.Discussion----------[FrameworkBundle] Fixed replace argument of `routing.loader` service| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Fixsymfony/symfony#31702> (1/1) OutOfBoundsExceptionThe index "2" is not in the range [0, 1].https://github.com/symfony/symfony/blob/bd8d8a2cfd50dffb4aa07908865931fb82a9e7bf/src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php#L33Commits-------5e2e79dbb9 Fixed replace argument of `routing.loader` service
nicolas-grekas added a commit that referenced this pull requestJun 6, 2019
…der` service (yceruto)This PR was merged into the 5.0-dev branch.Discussion----------[FrameworkBundle] Fixed replace argument of `routing.loader` service| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Fix#31702> (1/1) OutOfBoundsExceptionThe index "2" is not in the range [0, 1].https://github.com/symfony/symfony/blob/bd8d8a2cfd50dffb4aa07908865931fb82a9e7bf/src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php#L33Commits-------5e2e79d Fixed replace argument of `routing.loader` service
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr left review comments

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@TobionTobionTobion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Simperfit@nicolas-grekas@Tobion@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp