NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] The methods of the deprecated event should be final#31701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Simperfit wants to merge1 commit intosymfony:4.4fromSimperfit:made-final-to-prepare-the-cleaning-in-http-kernel

Closed

[HttpKernel] The methods of the deprecated event should be final#31701

Simperfit wants to merge1 commit intosymfony:4.4fromSimperfit:made-final-to-prepare-the-cleaning-in-http-kernel

Conversation

Copy link

Contributor

Simperfit commentedMay 29, 2019

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	none
License	MIT
Doc PR	none

This PRs allows to change the return types in 5.0 of the differents methods of the deprecated events class.

As said in#31672 (comment)

[HttpKernel] The methods of the deprecated event should be final

64a2ee0

carsonbot added Status: Needs Review HttpKernel labels

May 29, 2019

nicolas-grekas reviewed

May 29, 2019

View reviewed changes

src/Symfony/Component/HttpKernel/Event/FilterControllerEvent.php

		/**
		* Returns the current controller.
		*
		* @final since Symfony 4.4

Copy link

Member

nicolas-grekasMay 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sorry if that wasn't clear, but this is needed only for NON deprecated classes.

Copy link

ContributorAuthor

Simperfit commentedMay 29, 2019 via email

They extends these, so Do i copy past them now ?Le mer. 29 mai 2019 à 19:40, Nicolas Grekas <notifications@github.com> aécrit :

…

***@***.**** commented on this pull request. ------------------------------ In src/Symfony/Component/HttpKernel/Event/FilterControllerEvent.php <#31701 (comment)>: > @@ -31,6 +31,8 @@ public function __construct(HttpKernelInterface $kernel, callable $controller, R /** * Returns the current controller. * + *@Final since Symfony 4.4 sorry if that wasn't clear, but this is needed only for NON deprecated classes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31701?email_source=notifications&email_token=AA2KV4UD7VKR6VYWIV7QCF3PX252NA5CNFSM4HQO6DW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2BDSPY#pullrequestreview-243415359>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2KV4RU2DD6YIDIFNSKFK3PX252NANCNFSM4HQO6DWQ> .