Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Remove CsvEncoder "as_collection" deprecation & change default value#31684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:masterfromogizanagi:rm_deprec/serializer/csv_collectionMay 29, 2019
Merged
[Serializer] Remove CsvEncoder "as_collection" deprecation & change default value#31684
nicolas-grekas merged 1 commit intosymfony:masterfromogizanagi:rm_deprec/serializer/csv_collectionMay 29, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedMay 29, 2019
Thank you@ogizanagi. |
nicolas-grekas added a commit that referenced this pull requestMay 29, 2019
…on & change default value (ogizanagi)This PR was merged into the 5.0-dev branch.Discussion----------[Serializer] Remove CsvEncoder "as_collection" deprecation & change default value| Q | A| ------------- | ---| Branch? | master <!-- see below -->| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes (AppVeyor failure unrelated. Seehttps://github.com/symfony/symfony/pull/31685/files) <!-- please add some, will be required by reviewers -->| Fixed tickets |#27715 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/A <!-- required for new features -->As planned in#27715Commits-------22dd071 [Serializer] Remove CsvEncoder "as_collection" deprecation & change default value
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As planned in#27715