Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Remove deprecated implementation of ChoiceLoaderInterface in intl forms#31665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:masterfromyceruto:rm_intl_form_type_deprecationMay 29, 2019
Merged
[Form] Remove deprecated implementation of ChoiceLoaderInterface in intl forms#31665
nicolas-grekas merged 1 commit intosymfony:masterfromyceruto:rm_intl_form_type_deprecationMay 29, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
yceruto commentedMay 28, 2019
Status: Needs Work |
bbe40d5 to08307c3CompareMemberAuthor
yceruto commentedMay 28, 2019
(Tests failures unrelated) Status: Needs Review |
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas requested changesMay 29, 2019
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please move the addedstatic to a PR for 4.4
08307c3 tob22cbf4Comparenicolas-grekas approved these changesMay 29, 2019
Member
nicolas-grekas commentedMay 29, 2019
Thank you@yceruto. |
nicolas-grekas added a commit that referenced this pull requestMay 29, 2019
…nterface in intl forms (yceruto)This PR was merged into the 5.0-dev branch.Discussion----------[Form] Remove deprecated implementation of ChoiceLoaderInterface in intl forms| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -See previous PR#26825 (4.1)Commits-------b22cbf4 Remove deprecated implementation of ChoiceLoaderInterface in intl forms
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See previous PR#26825 (4.1)