Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping#31654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@vilius-g
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

#31604 but refactored for 3.4

…ccel-MappingCurrently BinaryFileResponse, when configured with X-Accel-Redirect sendfile type,will only substitute file paths specified in X-Accel-Mapping. But if the providedfile path does not have a defined prefix, then the resulting header will includethe absolute path. Nginx expects a valid URI, therefore this will result in anissue that is very hard to detect and debug as it will not show up in error logsand instead the request would just hang for some time and then be re-servedwithout query parameters(?).
@nicolas-grekas
Copy link
Member

Thank you@vilius-g.

@nicolas-grekasnicolas-grekas merged commita662f61 intosymfony:3.4May 29, 2019
nicolas-grekas added a commit that referenced this pull requestMay 29, 2019
…side of X-Accel-Mapping (vilius-g)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |#31604 but refactored for 3.4Commits-------a662f61 [HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping
@vilius-gvilius-g deleted the fix-x-accel-redirect-mismatch-3.4 branchMay 29, 2019 12:36
@fabpotfabpot mentioned this pull requestMay 30, 2019
This was referencedJun 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@vilius-g@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp