Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] allow answer to be trimmed by adding a flag#31626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Simperfit
Copy link
Contributor

@SimperfitSimperfit commentedMay 26, 2019
edited by chalasr
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone
LicenseMIT
Doc PRsymfony/symfony-docs#11603

According to#23210 (comment) we add a new flag in theQuestion class to be able to not trim the answer.

@SimperfitSimperfitforce-pushed thefeature/allow-answer-to-be-trimmed branch 3 times, most recently from39a3bb9 to3f60320CompareMay 26, 2019 16:26
@Simperfit
Copy link
ContributorAuthor

fabbot failure is a false positive

@chalasrchalasr added this to thenext milestoneMay 26, 2019
@SimperfitSimperfitforce-pushed thefeature/allow-answer-to-be-trimmed branch from3f60320 to782c2caCompareMay 26, 2019 16:30
@SimperfitSimperfitforce-pushed thefeature/allow-answer-to-be-trimmed branch 2 times, most recently from6cef233 tode53851CompareMay 31, 2019 08:34
@SimperfitSimperfit changed the base branch frommaster to4.4May 31, 2019 08:34
@SimperfitSimperfitforce-pushed thefeature/allow-answer-to-be-trimmed branch fromde53851 toc355ee0CompareMay 31, 2019 08:35
@Simperfit
Copy link
ContributorAuthor

@chalasr update to 4.4 and review fixed

@SimperfitSimperfitforce-pushed thefeature/allow-answer-to-be-trimmed branch from92091ff to8f182d8CompareJune 5, 2019 05:34
@Simperfit
Copy link
ContributorAuthor

AppVeyor failure is unrelated, PR rebased

4.4.0
-----

* added`Question::setTrimmable` default to true to allow the answer to be trimmed or not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's remove theor not

@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit8f182d8 intosymfony:4.4Jul 8, 2019
fabpot added a commit that referenced this pull requestJul 8, 2019
…(Simperfit)This PR was merged into the 4.4 branch.Discussion----------[Console] allow answer to be trimmed by adding a flag| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |symfony/symfony-docs#11603 <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->According to#23210 (comment) we add a new flag in the `Question` class to be able to not trim the answer.Commits-------8f182d8 [Console] allow answer to be trimmed by adding a flag
@SimperfitSimperfit deleted the feature/allow-answer-to-be-trimmed branchJuly 8, 2019 12:29
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr left review comments

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@apfelboxapfelboxapfelbox left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Simperfit@fabpot@apfelbox@chalasr@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp