Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] allow answer to be trimmed by adding a flag#31626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
39a3bb9 to3f60320CompareSimperfit commentedMay 26, 2019
fabbot failure is a false positive |
3f60320 to782c2caCompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
6cef233 tode53851Comparede53851 toc355ee0CompareSimperfit commentedJun 4, 2019
@chalasr update to 4.4 and review fixed |
Uh oh!
There was an error while loading.Please reload this page.
92091ff to8f182d8CompareSimperfit commentedJun 5, 2019
AppVeyor failure is unrelated, PR rebased |
| 4.4.0 | ||
| ----- | ||
| * added`Question::setTrimmable` default to true to allow the answer to be trimmed or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's remove theor not
fabpot commentedJul 8, 2019
Thank you@Simperfit. |
…(Simperfit)This PR was merged into the 4.4 branch.Discussion----------[Console] allow answer to be trimmed by adding a flag| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | none <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |symfony/symfony-docs#11603 <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->According to#23210 (comment) we add a new flag in the `Question` class to be able to not trim the answer.Commits-------8f182d8 [Console] allow answer to be trimmed by adding a flag
Uh oh!
There was an error while loading.Please reload this page.
According to#23210 (comment) we add a new flag in the
Questionclass to be able to not trim the answer.