Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Disable the SchemaAssetsFilter when setup the transport#31625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] Disable the SchemaAssetsFilter when setup the transport#31625
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vincenttouzet commentedMay 26, 2019
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31623 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
chalasr commentedMay 26, 2019
Tests seem broken |
vincenttouzet commentedMay 26, 2019
Yes I'm on it 😉 |
638cffd to1536f42Compare1536f42 to8cbb8f8Comparevincenttouzet commentedMay 26, 2019
Well the fix is uglier than I thought 🤔 As of Doctrine 2.9 the method to configure the assets filter has changed :doctrine/dbal@111e42d doctrine-dbal 2.9 introduce the new methods So I need to try if the method exists before |
weaverryan commentedMay 26, 2019
Quick work - thanks! Yea, that got ugly :). I can't think of another way either - can anyone else? If not, I think we need this - without it, it's an even uglier situation for the user. |
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's merge as is for 4.3. We will have time to tweak it if possible in 4.4.
fabpot commentedMay 27, 2019
Thank you@vincenttouzet. |
…transport (vincenttouzet)This PR was merged into the 4.3 branch.Discussion----------[Messenger] Disable the SchemaAssetsFilter when setup the transport| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#31623| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Commits-------8cbb8f8 [Messenger] Disable the SchemaAssetsFilter when setup the transport
…es on setup (MatTheCat)This PR was merged into the 5.4 branch.Discussion----------[Messenger] Make Doctrine connection ignore unrelated tables on setup| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#49108| License | MITIntrospecting the whole database can cause issues like Doctrine crashing on unknown column types. This PR updates the schema assets filter (added by#31625) to only consider the messages table, as it is the only one a connection setup needs to care about.Commits-------22dab67 [Messenger] Make Doctrine connection ignore unrelated tables on setup