Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] Do not trigger extra guard#31585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
lyrixx commentedMay 22, 2019
| Q | A |
|---|---|
| Branch? | 4.2 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31582 |
| License | MIT |
| Doc PR |
fabpot added a commit that referenced this pull requestMay 27, 2019
This PR was merged into the 3.4 branch.Discussion----------[Workflow] Do not trigger extra guards| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31582| License | MIT| Doc PR |---With this patch, guards are executed only on wanted transitions**Note for merger**: This is already fixed (in a different manner) in 4.2, So this patch should not be included in 4.2, instead take:#31585 or discard changes of Workflow class but keep testsCommits-------ad06197 [Workflow] Do not trigger extra guard
Member
xabbuh commentedMay 27, 2019
Shouldn't this test be present after merging the |
MemberAuthor
lyrixx commentedMay 27, 2019
Yes. I'm not sure how the merge will work because there will be some conflicts. |
Member
fabpot commentedMay 27, 2019
I've already merged 3.4 in 4.2, so I think this one is not needed anymore. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.